Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error when registering TomEE 10 #7598

Merged
merged 1 commit into from
Jul 21, 2024
Merged

Fix error when registering TomEE 10 #7598

merged 1 commit into from
Jul 21, 2024

Conversation

pepness
Copy link
Member

@pepness pepness commented Jul 19, 2024

  • TomcatFactory does not return correct TomEE version when registering TomEE 10
  • TomEE 10 support Jakarta EE 10
  • TomEE 10 support JPA 3.1

NetBeans Testing:

  • Verify successful execution of libraries and licenses Ant test
  • Verify successful execution of Verify Sigtests
  • Verify successful execution of unit tests for module tomcat5
  • Started NetBeans and ensure the log didn't have any ERROR or new WARNINGS
  • Successfully register TomEE 10 and run a Jakarta EE 10 Web App

@pepness
- TomcatFactory does not return correct TomEE version when registering
4563386 
  TomEE 10
- TomEE 10 support Jakarta EE 10
- TomEE 10 support JPA 3.1
@pepness pepness added Java EE/Jakarta EE [ci] enable enterprise job enterprise [ci] enable enterprise job labels Jul 19, 2024
@pepness pepness added this to the NB23 milestone Jul 19, 2024
@pepness pepness self-assigned this Jul 19, 2024
matthiasblaesing
matthiasblaesing approved these changes Jul 21, 2024
View reviewed changes
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@pepness pepness merged commit 98ac8a4 into apache:master Jul 21, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasblaesing matthiasblaesing matthiasblaesing approved these changes

Assignees

@pepness pepness

Labels
enterprise [ci] enable enterprise job Java EE/Jakarta EE [ci] enable enterprise job
Projects
None yet
Milestone
NB23
Development

Successfully merging this pull request may close these issues.
2 participants
@pepness @matthiasblaesing